Skip to content

Change React Core dependency for Xcode 12#164

Closed
cte wants to merge 1 commit intoinvertase:masterfrom
cte:patch-1
Closed

Change React Core dependency for Xcode 12#164
cte wants to merge 1 commit intoinvertase:masterfrom
cte:patch-1

Conversation

@cte
Copy link

@cte cte commented Nov 16, 2020

I'm getting the following error when installing the Pod:

[!] Unable to find a specification for `React-Core` depended upon by `RNAppleAuthentication`

You have either:
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

error Command failed with exit code 1.

This change is based on: facebook/react-native#30018 (comment)

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mikehardy
Copy link
Collaborator

mikehardy commented Nov 16, 2020

What in the world? We just changed that line! #139 - this is disheartening, and that issue is still open.
I really appreciate that you took the time to PR this but I need to replicate it / investigate just a little bit before I do anything - that bug is from before Xcode 12.2 came out so I'm suspicous - there may be something else going on

@mikehardy mikehardy added bug Something isn't working ready-for-review labels Nov 16, 2020
@mikehardy mikehardy self-assigned this Nov 16, 2020
@cte
Copy link
Author

cte commented Nov 17, 2020

What in the world? We just changed that line! #139 - this is disheartening, and that issue is still open.
I really appreciate that you took the time to PR this but I need to replicate it / investigate just a little bit before I do anything - that bug is from before Xcode 12.2 came out so I'm suspicous - there may be something else going on

Great - thanks. LMK if you need any more information about the environment in which I can repro this.

@mikehardy
Copy link
Collaborator

mikehardy commented Nov 17, 2020

I can't reproduce this locally after updating to Big Sur overnight, and using Xcode 12.2
I'll need to see full environment details and a failing build log from the example app included in this repo, preferably after a npx react-native-clean-project in order to figure out what is going on and have a hope of understanding it

My only hunch at the moment is that perhaps the example is still on react-native 0.61.x and that's affecting it, but I also rebuilt my work app on react-native 0.63.x on the same Big Sur / Xcode 12.2 combo and everything was fine

🤔

@afestein
Copy link

afestein commented Dec 8, 2020 •
edited
Loading

I'm a little confused on this issue, there are many repos updating their podspec to 'React-Core' as outlined in the React Native issue.

I can see one other repo has reverted that change though, citing the same issue.

@mikehardy
Copy link
Collaborator

mikehardy commented Dec 8, 2020

@afestein I maintain a lot of repos and watch quite a few more, with respect I'm going to say I'm not that interested in what other repos are doing. I need to reproduce something or have someone show me a specific reproduction to act on something, especially a revert. As mentioned above, I cannot reproduce any problem, this is a closed issue to me, I should have closed it before as leaving it open implies there is some action I will take

If someone can post a reproduction, I will act immediately, until then it's not worth more attention

@mikehardy mikehardy closed this Dec 8, 2020
@cte cte deleted the patch-1 branch December 8, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mikehardy mikehardy

Labels

bug Something isn't working ready-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cte @CLAassistant @mikehardy @afestein